-
Notifications
You must be signed in to change notification settings - Fork 750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve travis and appveyor builds #410
Conversation
ci/setupPackages.sh
Outdated
unzip hdf5.zip | ||
cd hdf5 | ||
msiexec //i HDF5-1.10.0-win32.msi //quiet | ||
cp -R /c/Program\ Files\ \(x86\)/HDF_Group /c/Program\ Files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldn't need a copy here since the presets look in the default installation directory.
Looks good! Thanks! Apart from my comments inline, Yeah, I'll need to figure out how to pick up some "releases" for MXNet. It's not entirely clear what their system is. But we're going to hit limits building all of that + Caffe. I'm currently working on the loader and builder in JavaCPP so that we can have it install and load everything--including header files--in |
Pretty much all in apart from the hdf5 part - from what I've tested there needs to be either a cp or mv, because the install puts it in a Program Files (x86) as its installing on a win64 build server. From a few tests, I seem to get issues if I try mv but not cp (maybe something else during the build looks back to the x86 dir from a path or something?). So seemed easiest to go with that |
I mean, the presets for HDF5 when building for windows-x86 are going to look into |
Strange.. that suggests to me its a bug.. (I assumed on a native win32
setup, maybe Program Files becomes the 32bit program files or something
like that). Will double check..
…On 24 April 2017 at 12:47, Samuel Audet ***@***.***> wrote:
I mean, the presets for HDF5 when building for windows-x86 are going to
look into "C:/Program Files (x86)/HDF_Group/HDF5/1.10.0/". If they are not,
then it's a bug:
https://github.com/bytedeco/javacpp-presets/blob/master/
hdf5/src/main/java/org/bytedeco/javacpp/presets/hdf5.java#L49
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#410 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AMYRJxIAMCXvlcLcEsGYydkp7MzM9oKTks5rzIvigaJpZM4NDhVg>
.
|
Appveyor build changed to split out some package config into a bash file, gives more flexibility around logic for what packages to install so we can save time and improve reliability there. Looks to build the whole lot OK now. Also more readable, text it platform then project so you can see on the main screen what's going on.
Travis build updated to the point where I think everything builds apart from mxnet. I guess that might be the risk of building against a master repo point rather than a release, you can catch upstream bugs/impacts on yours (I'm guessing thats the issue rather than build config but I don't know for sure).
CUDA problem fixed by separating out the download rather than using brew.
I'm seeing occasional failures due to downloads, wonder if they have intermittent connection issues. Down the road, could put some retry logic, but easy enough just to hit the 'rebuild' button if you see a connection issue in the log.