Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve travis and appveyor builds #410

Merged
merged 77 commits into from
Apr 27, 2017
Merged

improve travis and appveyor builds #410

merged 77 commits into from
Apr 27, 2017

Conversation

vb216
Copy link
Member

@vb216 vb216 commented Apr 20, 2017

Appveyor build changed to split out some package config into a bash file, gives more flexibility around logic for what packages to install so we can save time and improve reliability there. Looks to build the whole lot OK now. Also more readable, text it platform then project so you can see on the main screen what's going on.

Travis build updated to the point where I think everything builds apart from mxnet. I guess that might be the risk of building against a master repo point rather than a release, you can catch upstream bugs/impacts on yours (I'm guessing thats the issue rather than build config but I don't know for sure).

CUDA problem fixed by separating out the download rather than using brew.

I'm seeing occasional failures due to downloads, wonder if they have intermittent connection issues. Down the road, could put some retry logic, but easy enough just to hit the 'rebuild' button if you see a connection issue in the log.

unzip hdf5.zip
cd hdf5
msiexec //i HDF5-1.10.0-win32.msi //quiet
cp -R /c/Program\ Files\ \(x86\)/HDF_Group /c/Program\ Files
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't need a copy here since the presets look in the default installation directory.

@saudet
Copy link
Member

saudet commented Apr 23, 2017

Looks good! Thanks! Apart from my comments inline, setupPackages.sh, maybe install-windows.sh would be better for self-documentation?

Yeah, I'll need to figure out how to pick up some "releases" for MXNet. It's not entirely clear what their system is. But we're going to hit limits building all of that + Caffe. I'm currently working on the loader and builder in JavaCPP so that we can have it install and load everything--including header files--in .m2/repository, as explained at bytedeco/javacpp#43 . This way, as long as we specify that directory in the cache, and list projects after their dependencies, it should work automagically. Getting Maven to cooperate with all that is a bit challenging, but I should get it working, soonish. :)

@vb216
Copy link
Member Author

vb216 commented Apr 23, 2017

Pretty much all in apart from the hdf5 part - from what I've tested there needs to be either a cp or mv, because the install puts it in a Program Files (x86) as its installing on a win64 build server. From a few tests, I seem to get issues if I try mv but not cp (maybe something else during the build looks back to the x86 dir from a path or something?). So seemed easiest to go with that

@saudet
Copy link
Member

saudet commented Apr 24, 2017

I mean, the presets for HDF5 when building for windows-x86 are going to look into
"C:/Program Files (x86)/HDF_Group/HDF5/1.10.0/". If they are not, then it's a bug:
https://github.com/bytedeco/javacpp-presets/blob/master/hdf5/src/main/java/org/bytedeco/javacpp/presets/hdf5.java#L49

@vb216
Copy link
Member Author

vb216 commented Apr 24, 2017 via email

@saudet saudet merged commit 737696d into bytedeco:master Apr 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants