-
Notifications
You must be signed in to change notification settings - Fork 747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds ONNX Optimizer, Version Converter and IR. #622
Conversation
…xception` annotation * Fix `Parser` failures on variadic function template arguments `...` and destructor attributes (pull bytedeco/javacpp-presets#622)
Looks good! I've fixed this up in JavaCPP, so let me know if you encounter any other issues or when this is ready to merge, thanks! |
Thanks for the fixes! I tested check_model and added it to the README. When I try Optimize(...) I get :
|
Similarly for InferShapes(...) :
Although it required a few changes I haven't pushed yet to get there. I still need to test version conversion. |
That sounds like the build is missing some options that would include those symbols in the library. |
Yeah, that was my first thought too. The thing is, there don't seem to be any build options for this, it should already be there in the libonnx.so. There's no mention of build options in the docs: And in fact the .so matches when I grep for the function names ( |
Check with |
|
|
Actually, that was installing from platform without installing the local build first. |
Damn.. It turns out that, yep, it was the same issue as a few months ago, my local was not being used. |
Ready to merge! still haven't figured out how to maven install platform without getting the |
Yup, it's working fine here! Thanks. Good to merge? |
Yep, good to merge. |
The goal here is being able to "polish" a model, as well as convert it to the latest version, via the preset.
Some notes:
virtual
andinline
for constructor declarations