[CUDA] Removed missing Java 9 package exports #880
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The produced cuda jar is now considered valid as a Java 9 module.
I'm not sure if the packages being missing are a symptom of an underlying issue, or if the module file was in error. I also checked a few of the other Jars (any jar that was being used by deeplearning4j to be precise) and they all are accepted into a Java 9+ build.
The command
java -p JAR --describe-module MODULE
can be used to check any produced jars.Old
Fixed
Changes