Fix template substitution with const #677
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you instantiate this template with
int *
, then the resulting type should beint * const *
and notconst int **
.But the parser produces this, with a
new Info("X<int *>").pointerTypes("XI")
:Leading to JNI compile error since the constructor expects a
int * const*
.This PR tries to fix this. It seems to do the trick. The parser now emits:
The
const
doesn't appear in the cast at all, but at least we have a better chance to compile the JNI.I'm not sure it generalizes well. Can we do something better ?