-
Notifications
You must be signed in to change notification settings - Fork 588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow override of compiler flags #90
Allow override of compiler flags #90
Conversation
JVM complained with "Java HotSpot(TM) Server VM warning: You have loaded library XXX which might have disabled stack guard. The VM will try to fix the stack guard now. It's highly recommended that you fix the library with 'execstack -c ', or link it with '-z noexecstack'"
We can't always have the default included because flags like |
I'll have to think about how to best approach it. I included It does seem odd to me that a different architecture is buried inside a |
The idea was that the user could manually reinclude "default" if it was required for build. Leaving it the way it was shouldn't break any existing code ...Do you have an example? |
Looking through the By splitting Here's an idea: what if the resource files were left as-is the same but |
Putting I like the idea of having "debug" and "release", that's fine, but we somehow need to keep the current functionality working, in this case, on the android-arm platform, that's all. |
Right, but now I remember, everything after BTW, I believe "debug" and "release" should be builder options. It might make things easier to think of them that way too, but I'm not too sure about how this should all work. I'm open to proposals. |
FWIW, for projects that require more powerful C++ build options, I recommend generating the source code with |
…roperties file (pull #90) * Always use the `platform.compiler.default` options unless `@Platform(compiler="!default", ...)` is specified * Move optimization options from `platform.compiler.output` to `platform.compiler.default`, allowing users to override
I've finally figured out what to do about this: Allow users to disable the "default" options. Specifically, with |
Reasoning
I needed to add lower optimization levels but the
-O3
was inserted last and override my choice. This makes thedefault
property always included and appends on any other compiler options.Note
Tested on
linux-x86_64
,windows-x86_64
,windows-x86
, andmac-x86_64
. I couldn't test other platforms