Fixed an issue with blank dashboard on login #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khushi818
requested review from
abhinandanwadwa,
devarshishimpi and
Ravina-Deogadkar
abhinandanwadwa
approved these changes
Oct 12, 2022
devarshishimpi
approved these changes
Oct 12, 2022
Ravina-Deogadkar
approved these changes
Oct 12, 2022
devarshishimpi
added
bug
|
@IncredibleZuess Thanks Again!! With helping for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
The problem which was occurring can be summed up here:
If the token variable is set at the start of a file it takes the original value. As a result your access-token is not reactive, its not getting the new value from sessionStorage.
Screenshots - If Any (Optional)
Issue ticket number and link - If Any
closes: #108
Checklist before requesting a review
I have performed a self-review of my code.
Followed the repository's Contributing Guidelines.
I ran the app and tested it locally to verify that it works as expected.
I have starred the repository.
Additional Information (Optional)
This took a really long time to figure out.
It was super fun :)