Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sitemap generation #141

Merged

Conversation

ron-huberfeld
Copy link
Contributor

Describe your changes

Add express-site-xml dependency and create a script to generate sitemap.xml which runs on prestart script.

Screenshots - If Any (Optional)

Issue ticket number and link - If Any

Issue #119

Checklist before requesting a review

  • I have performed a self-review of my code.

  • Followed the repository's Contributing Guidelines.

  • I ran the app and tested it locally to verify that it works as expected.

  • I have starred the repository.

Additional Information (Optional)

Still missing in the script - to generate the map dynamically on routes changes.

Copy link
Member

@devarshishimpi devarshishimpi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!! I think this works as of now,

@devarshishimpi devarshishimpi merged commit 999f208 into bytemakers:main Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants