Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies, resolve external-facing deprecations #27

Merged
merged 5 commits into from
Oct 26, 2022
Merged

Conversation

GaryGSC
Copy link
Member

@GaryGSC GaryGSC commented Oct 26, 2022

This was a quick stab at resolving 2.5yrs of tech debt.

This is technically a breaking change due to requiring a newer version of the GitHub runner that can handle using: 'node16', but otherwise it should be a very safe update. At BYU, with the exceptions of an on-prem runner or two and the mobile app team needing Macs, we use runs-on: 'ubuntu-latest'. The breaking change should be a non-issue.

Dev deps looked like they were going to be a pain with all the
tsc/eslint updates over the years.
We're not using any Node.js-specific calls, so this should be a very
safe update.
@github-actions
Copy link

github-actions bot commented Oct 26, 2022

Terraform Plan in different dir:

will create 2 resources:

  • local_file - fake_file
  • random_pet - name

see details

@github-actions
Copy link

github-actions bot commented Oct 26, 2022

Terraform Plan without wrapper:

will create 2 resources:

  • local_file - fake_file
  • random_pet - name

see details

@github-actions
Copy link

github-actions bot commented Oct 26, 2022

Terraform Plan from root:

will create 2 resources:

  • local_file - fake_file
  • random_pet - name

see details

@github-actions
Copy link

github-actions bot commented Oct 26, 2022

Terraform Plan:

will create 2 resources:

  • local_file - fake_file
  • random_pet - name

see details

@GaryGSC GaryGSC requested review from yoshutch and a team October 26, 2022 20:29
Copy link

@stuft2 stuft2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for the linting errors, LGTM.

@GaryGSC
Copy link
Member Author

GaryGSC commented Oct 26, 2022

The lint warnings are odd because they're complaining that I'm passing in an object with a run_id property to a dependency (to pick an example). @stuft2 - Any suggestions on how to fix that?

Maybe if I were to update ESLint and a bunch of the dev dependencies, we'd get different lint errors. It just looked like a royal pain to update those due to all the config files and peer dependencies.

@stuft2
Copy link

stuft2 commented Oct 26, 2022

Unfortunately, I think the only way to get around this is to disable the rule. You could disable it globally but I prefer to disable it per line unless the effort outweighs the benefit.

const example = {
// eslint-disable-next-line @typescript-eslint/naming-convention
  run_id: '<id>'
}

@GaryGSC
Copy link
Member Author

GaryGSC commented Oct 26, 2022

I agree about the per-line/global thing. I'll go ahead and make those changes here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants