-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies, resolve external-facing deprecations #27
Conversation
Dev deps looked like they were going to be a pain with all the tsc/eslint updates over the years.
We're not using any Node.js-specific calls, so this should be a very safe update.
Terraform Plan in different dir:will create 2 resources:
|
Terraform Plan without wrapper:will create 2 resources:
|
Terraform Plan from root:will create 2 resources:
|
Terraform Plan:will create 2 resources:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except for the linting errors, LGTM.
The lint warnings are odd because they're complaining that I'm passing in an object with a Maybe if I were to update ESLint and a bunch of the dev dependencies, we'd get different lint errors. It just looked like a royal pain to update those due to all the config files and peer dependencies. |
Unfortunately, I think the only way to get around this is to disable the rule. You could disable it globally but I prefer to disable it per line unless the effort outweighs the benefit. const example = {
// eslint-disable-next-line @typescript-eslint/naming-convention
run_id: '<id>'
} |
I agree about the per-line/global thing. I'll go ahead and make those changes here. |
This was a quick stab at resolving 2.5yrs of tech debt.
This is technically a breaking change due to requiring a newer version of the GitHub runner that can handle
using: 'node16'
, but otherwise it should be a very safe update. At BYU, with the exceptions of an on-prem runner or two and the mobile app team needing Macs, we useruns-on: 'ubuntu-latest'
. The breaking change should be a non-issue.