Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split up Deploy workflow into multiple jobs #706

Merged
merged 1 commit into from
Oct 31, 2022
Merged

Split up Deploy workflow into multiple jobs #706

merged 1 commit into from
Oct 31, 2022

Conversation

GaryGSC
Copy link
Member

@GaryGSC GaryGSC commented Oct 31, 2022

I added a hadolint job under the assumption that #705 would be accepted.

Here, we take several steps that were part of the one and only job, and split them out into separate jobs so that those steps can be run in parallel. This parallelization should reduce deployment times.

This was a simple first attempt, but there is some further work that we could do:

  • Use reusable workflows to DRY up some code shared between CI and deployments
  • Move Docker build/push into a separate job
    • Potentially complicated because ideally we'd have a single build with multiple pushes for multiple environments
  • Move TF plan analysis to a separate job
    • Potentially complicated because we'd like to re-use the plan, which might get weird with the way terraform-setup wraps outputs

Closes #541
Closes #677

@GaryGSC GaryGSC requested a review from a team October 31, 2022 20:35
Copy link
Member

@joshgubler joshgubler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Faster terraform fmt!

@GaryGSC GaryGSC merged commit b640713 into dev Oct 31, 2022
@GaryGSC GaryGSC deleted the split-up-deploy branch October 31, 2022 21:19
@GaryGSC
Copy link
Member Author

GaryGSC commented Oct 31, 2022

On the plus side, we no longer test/audit/lint multiple times if we're deploying to multiple environments!

This was referenced Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants