Attempt to fix terraform outputs in GHA #713
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on this line (and this code, which shouldn't print
"
s unless those were instdout.contents
), I think something in setup-terraform's approach to catching stdout is adding the"
s.This approach avoids setup-terraform's stdout to output process entirely and allows us to consolidate 4 steps into 1, which looks cleaner in my opinion (and might shave off a second or two, since we don't need to start processes and shells for each step).
I haven't actually tested this new process yet.