Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix terraform outputs in GHA #713

Merged
merged 1 commit into from
Nov 2, 2022
Merged

Attempt to fix terraform outputs in GHA #713

merged 1 commit into from
Nov 2, 2022

Conversation

GaryGSC
Copy link
Member

@GaryGSC GaryGSC commented Nov 2, 2022

Based on this line (and this code, which shouldn't print "s unless those were in stdout.contents), I think something in setup-terraform's approach to catching stdout is adding the "s.

This approach avoids setup-terraform's stdout to output process entirely and allows us to consolidate 4 steps into 1, which looks cleaner in my opinion (and might shave off a second or two, since we don't need to start processes and shells for each step).

I haven't actually tested this new process yet.

@GaryGSC GaryGSC requested a review from joshgubler November 2, 2022 16:23
@GaryGSC GaryGSC merged commit 2a6951b into dev Nov 2, 2022
@GaryGSC GaryGSC deleted the terraform-output branch November 2, 2022 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants