Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require AWS provider >= 3.69, allow passing in cpu_architecture for ARM #38

Merged
merged 3 commits into from
Oct 25, 2022
Merged

Require AWS provider >= 3.69, allow passing in cpu_architecture for ARM #38

merged 3 commits into from
Oct 25, 2022

Conversation

GaryGSC
Copy link
Member

@GaryGSC GaryGSC commented Oct 25, 2022

I based this PR off of my previous one (#37), since I was thinking we could cut a v5.0.0 release that contains both sets of changes.

@github-actions
Copy link

github-actions bot commented Oct 25, 2022 •
edited
Loading

Terraform Plan:

will create 26 resources:

  • aws_efs_file_system - my_efs
  • aws_alb - alb
  • aws_alb_listener - http_to_https
  • aws_alb_listener - https
  • aws_alb_listener - test_listener
  • aws_alb_target_group - blue
  • aws_alb_target_group - green
  • aws_cloudwatch_log_group - container_log_group
  • aws_cloudwatch_log_group - xray_log_group
  • aws_codedeploy_app - app
  • aws_codedeploy_deployment_group - deploymentgroup
  • aws_ecs_cluster - new_cluster
  • aws_ecs_service - service
  • aws_ecs_task_definition - task_def
  • aws_iam_policy - secrets_access
  • aws_iam_role - task_execution_role
  • aws_iam_role - task_role
  • aws_iam_role_policy_attachment - secret_task_policy_attach
  • aws_iam_role_policy_attachment - secrets_policy_attach
  • aws_iam_role_policy_attachment - task_execution_policy_attach
  • aws_iam_role_policy_attachment - xray_task_policy_attach
  • aws_route53_record - a_record
  • aws_route53_record - aaaa_record
  • aws_security_group - alb-sg
  • aws_security_group - fargate_service_sg
  • local_file - appspec_json

see details

@GaryGSC GaryGSC changed the title Allow passing in cpu_architecture so that we can use ARM-based images Require AWS provider >= 3.69, allow passing in cpu_architecture for ARM Oct 25, 2022
@GaryGSC GaryGSC mentioned this pull request Oct 25, 2022
Merged
@GaryGSC GaryGSC requested a review from a team October 25, 2022 20:13
@GaryGSC GaryGSC mentioned this pull request Oct 25, 2022
Merged
@GaryGSC GaryGSC merged commit 9d8e64f into master Oct 25, 2022
@GaryGSC GaryGSC deleted the cpu-architecture branch October 25, 2022 21:16
@GaryGSC
Copy link
Member Author

GaryGSC commented Oct 25, 2022

Released! See the release notes for info on how to build and deploy using ARM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuft2 stuft2 stuft2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GaryGSC @stuft2