Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added sort all flag to the Verilog composer #190

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

ganeshgore
Copy link
Contributor

In some cases, the composed netlist is maintained in version controlled system. which expects the deterministic output during every run. Setting sort_all flag to true, sort each element in the Verilog netlist (like input/output declaration, instance declaration, and ports, declarations).

@jacobdbrown4
Copy link
Collaborator

This is a good option. And thanks for setting the pull request to go to the next_release branch. We have other changes that have been pushed to the next release branch that conflict with this though. Can you maybe update your side to match our next_release branch and then we can merge it in?

@jacobdbrown4 jacobdbrown4 changed the base branch from next_release_broken to next_release April 13, 2023 17:22
@jacobdbrown4
Copy link
Collaborator

@ganeshgore thanks for adding this feature. Can you resolve the conflicts? And then I'll accept the pull request.

@jacobdbrown4
Copy link
Collaborator

@ganeshgore I merged your other pull request but now that caused this one to have conflicts. You may have to update your composer_sort_all branch now.

@jacobdbrown4 jacobdbrown4 merged commit f004a84 into byuccl:next_release Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants