skip line erasing on render when window size is not yet available #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, I had no idea. Thanks. |
c-bata
reviewed
Feb 12, 2018
| // Erasing | ||
| r.out.CursorBackward(int(r.col) + len(buffer.Text()) + len(prefix)) | ||
| r.out.EraseDown() | ||
| if r.col > 0 { |
There was a problem hiding this comment.
Could you add a following comment before this line?
In situations where a psuedo tty is allocated (e.g. within a docker container), window size via TIOCGWINSZ is not immediately available and will result in 0,0 dimensions.
There was a problem hiding this comment.
I'll add after merge this. thanks.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In situations where a psuedo tty is allocated (e.g. within a docker container), window size via
TIOCGWINSZis not immediately available and will result in0,0dimensions, causing a divide by 0 error whenRender()is called before the tty is fully setup.However, in such circumstances,
SIGWINCHis emitted when the psuedo tty allocation is complete. This change allowsgo-promptto skip erase / height calculations when the initial window size is fetched (manually) as0and proceed as normal once the winch signal is received.