Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove Trace module, focus on Trace_core #20

Closed
wants to merge 2 commits into from
Closed

remove Trace module, focus on Trace_core #20

wants to merge 2 commits into from

Conversation

c-cube
Copy link
Owner

@c-cube c-cube commented Oct 6, 2023

remove Trace module, since it conflicts with toplevel. We can always use Trace_core and the trace library re-exports it.

@c-cube c-cube requested a review from ELLIOTTCABLE October 13, 2023 02:25
@ELLIOTTCABLE
Copy link
Collaborator

I still vaguely feel like it's silly to stick with the name “trace” thanks to this — doesn't it seem silly to have everybody in the ecosystem typing out …

Trace_core.span …

wdyt about, idk, Trce or OTrace or something? i don't relish renaming all the things, announce it … but i also don't love imaging the verbose “Trace_core" being the go-to for everything 💀

@c-cube c-cube closed this Oct 31, 2023
@c-cube
Copy link
Owner Author

c-cube commented Oct 31, 2023

closing this, I think no solution is better than the status quo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ELLIOTTCABLE ELLIOTTCABLE Awaiting requested review from ELLIOTTCABLE

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@c-cube @ELLIOTTCABLE