Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trace-subscriber #32

Merged
merged 12 commits into from
Sep 17, 2024
Merged

trace-subscriber #32

merged 12 commits into from
Sep 17, 2024

Conversation

c-cube
Copy link
Owner

@c-cube c-cube commented Sep 9, 2024

No description provided.

@c-cube
Copy link
Owner Author

c-cube commented Sep 13, 2024

It might make more sense to put subscriber directly into the core library, for a more consistent setup. Internally, Trace_core could then have either:

  • nothing
  • a custom collector
  • a subscriber (or list of subscribers + tee) and a collector automatically derived from it

and provide setup functions that enforce these states consistently. That means we could add/remove subscribers on the fly if there already are subscribers or nothing.

@c-cube c-cube merged commit 11d313d into main Sep 17, 2024
4 checks passed
@c-cube c-cube deleted the simon/subscribers branch September 17, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant