Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align int generators #165

Merged
merged 4 commits into from
Aug 22, 2021
Merged

Align int generators #165

merged 4 commits into from
Aug 22, 2021

Conversation

jmid
Copy link
Collaborator

@jmid jmid commented Aug 18, 2021

The PR addresses issue #164 from PR #153.

  • It fixes the generation order of both QCheck/QCheck2 int generators to be left-middle-right like QCheck.Gen.int. This should be preferable to continue past behaviour and for reproducability.
  • It updates the expected QCheck2 output (bonus: with this change all reported stats are identical, yay!)
  • It pull out a Sys.word_size test, so that QCheck2.Gen.pint_raw only tests it once (not on every generator call)

@jmid
Copy link
Collaborator Author

jmid commented Aug 22, 2021

OK, I´m merging this one since it shouldnt be too controversial.

@jmid jmid merged commit a0a8282 into c-cube:master Aug 22, 2021
@jmid jmid deleted the align-int-generators branch September 8, 2021 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant