-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Krita plugin #102
Add Krita plugin #102
Conversation
We would like to thank you again for your contributions to make the G'MIC-Qt plugin work on Digikam and Krita. Having G'MIC-Qt working on different host applications is very valuable to us and we really appreciate the work you've accomplished for this purpose. The improvements of the new plugin version for Krita look good. Recently, we have thought long and hard about how we can incorporate contributions in the upstream repository For you, this means we will not incorporate your code or PR (in their current forms) in the In any case, we will be happy to share links to your alternative implementations when we become aware of their locations, here and on the official G'MIC website. Thanks again for all your efforts. Sébastien and David. |
It might be better to completely remove the krita host then because it will not work with Krita going forward. |
Shouldn't we keep it alive for older versions of Krita ? |
Not in the repository, the last release is good enough for that. |
Please remove digiKam plugin too... |
@boudewijnrempt @amyspark : We have decided to keep the 'old' version of the plug-in for Krita alive, until you release an official build of Krita that contains your new embedded version of the G'MIC-Qt plug-in. |
We have long since released a version of krita with our fork of the gmic-qt plugin. |
@hallarempt @amyspark Krita specific code has been removed (65a0e94) |
Hi @c-koi and @dtschump,
This PR is to upstream the changes I made to plugin-ify GMic-Qt in Krita. This work was done in !581.
It's mostly a port of the existing Krita host, but with the following changes: