Skip to content

Commit

Permalink
"Add" -> "Append"
Browse files Browse the repository at this point in the history
"Add" was a bit ambiguous on whether the items were added to the right
or to the left.

"Append" now implies items are added to the right.
  • Loading branch information
c032 committed Mar 3, 2024
1 parent 41fc081 commit 60d9a3f
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 6 deletions.
2 changes: 1 addition & 1 deletion cmd/dsts/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ func main() {
tn := &dststime.Notifier{}

must1(statusLine.AddNotifier(tn))
must1(statusLine.AddStatusLineBlocks(&tn.StatusUnix, &tn.StatusDateTime))
must1(statusLine.AppendStatusLineBlocks(&tn.StatusUnix, &tn.StatusDateTime))

err := statusLine.Run()
if err != nil {
Expand Down
11 changes: 6 additions & 5 deletions i3statusline.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,9 @@ var (

type I3StatusLine interface {
AddNotifier(notifier Notifier) error
AddStatusLineBlocks(block ...*atomic.Pointer[StatusLineBlock]) error
AddStatusLineBlockProvider(p StatusLineBlockProvider) error

AppendStatusLineBlocks(block ...*atomic.Pointer[StatusLineBlock]) error
AppendStatusLineBlockProvider(p StatusLineBlockProvider) error

Run() error
}
Expand Down Expand Up @@ -64,7 +65,7 @@ func (i3sl *i3StatusLine) AddNotifier(notifier Notifier) error {
return nil
}

func (i3sl *i3StatusLine) AddStatusLineBlocks(blocks ...*atomic.Pointer[StatusLineBlock]) error {
func (i3sl *i3StatusLine) AppendStatusLineBlocks(blocks ...*atomic.Pointer[StatusLineBlock]) error {
for _, block := range blocks {
if block == nil {
return ErrNilStatusLineBlock
Expand All @@ -76,7 +77,7 @@ func (i3sl *i3StatusLine) AddStatusLineBlocks(blocks ...*atomic.Pointer[StatusLi
return nil
}

func (i3sl *i3StatusLine) AddStatusLineBlockProvider(p StatusLineBlockProvider) error {
func (i3sl *i3StatusLine) AppendStatusLineBlockProvider(p StatusLineBlockProvider) error {
notifier, slb := slbpToNotifier(i3sl.ctx, p)

var err error
Expand All @@ -86,7 +87,7 @@ func (i3sl *i3StatusLine) AddStatusLineBlockProvider(p StatusLineBlockProvider)
return err
}

err = i3sl.AddStatusLineBlocks(slb)
err = i3sl.AppendStatusLineBlocks(slb)
if err != nil {
return err
}
Expand Down

0 comments on commit 60d9a3f

Please sign in to comment.