Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub action PR Issue checker #92

Merged
merged 2 commits into from
Oct 18, 2024
Merged

GitHub action PR Issue checker #92

merged 2 commits into from
Oct 18, 2024

Conversation

ygowthamr
Copy link
Contributor

@ygowthamr ygowthamr commented Oct 17, 2024 •
edited
Loading

What i have done :

  • Solved Adding GitHub action workflow for PR validation

Fixes #91

@c0sm0void
Pls add me labels like gssoc-extd,level2,hacktoberfest.

@github-actions GitHub Actions
Copy link
Contributor

Hi there! Thanks for submitting this pull request. We appreciate your contribution to this open-source project. We aim to review your pull request as soon as possible.

@whyvineet
Copy link
Collaborator

Working well when we don't give any description
Screenshot from 2024-10-17 23-49-49

While Giving the issue number the workflow is still giving error!
Screenshot from 2024-10-17 23-49-03

I'm not sure if this is case-sensitive or not but make sure it should be case-sensitive
Screenshot from 2024-10-17 23-49-24

whyvineet
whyvineet requested changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@whyvineet whyvineet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to fix all the errors mentioned in the above comment!

@ygowthamr
Copy link
Contributor Author

ygowthamr commented Oct 18, 2024 •
edited
Loading

@whyvineet

This are not errors if fixes keyboard and issue number is not mentioned in the description then this will occur

@ygowthamr
Copy link
Contributor Author

ygowthamr commented Oct 18, 2024 •
edited
Loading

Working well when we don't give any description
Screenshot from 2024-10-17 23-49-49

While Giving the issue number the workflow is still giving error!
Screenshot from 2024-10-17 23-49-03

I'm not sure if this is case-sensitive or not but make sure it should be case-sensitive
Screenshot from 2024-10-17 23-49-24

@whyvineet

Here you just kept like fix #2 right, so it is asking you to keep in Fixes #2

@ygowthamr ygowthamr requested a review from whyvineet October 18, 2024 04:31
@ygowthamr
Copy link
Contributor Author

@whyvineet
Please check now i have updated the code

@ygowthamr
Copy link
Contributor Author

@whyvineet @c0sm0void @mvp-2003

Anyone pls check and merge my pr

@ygowthamr
Copy link
Contributor Author

@whyvineet
Please check my pr and merge it

@whyvineet whyvineet merged commit fbe781f into c0sm0void:master Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whyvineet whyvineet whyvineet approved these changes

@c0sm0void c0sm0void Awaiting requested review from c0sm0void

@mvp-2003 mvp-2003 Awaiting requested review from mvp-2003

Assignees

@ygowthamr ygowthamr

Labels
gssoc-ext GirlScript Summer Of Code 2024 Extd hacktoberfest hacktoberfest-accepted level2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adding github action workflow for PR validation
3 participants
@ygowthamr @whyvineet @c0sm0void