Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show warning if bidCpmAdjustment is set for AOL bidder (closes #725) … #1

Merged
merged 1 commit into from
Oct 26, 2016

Conversation

jpteam
Copy link

@jpteam jpteam commented Oct 26, 2016

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other

Description of change

  • test parameters for validating bids
{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}
  • contact email of the adapter’s maintainer
  • official adapter submission

Other information

…(prebid#728)

…728)

* Show warning if bidCpmAdjustment is set for AOL bidder (closes #725)

* Show bidCpmAdjustment warning for AOL adapter only in debug mode

* Fix failing unit test for AOL adapter

- fix after implementation changed from console.warn to utils.logWarn
@jpteam jpteam merged commit a6be2a0 into c1x:master Oct 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show warning if bidCpmAdjustment is set for AOL bidder
2 participants