Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grace period for modern thumbnails on publish #227

Merged
merged 2 commits into from
Feb 22, 2023
Merged

Grace period for modern thumbnails on publish #227

merged 2 commits into from
Feb 22, 2023

Conversation

lbesson
Copy link
Member

@lbesson lbesson commented Feb 1, 2023 •
edited
Loading

solves #173

@lbesson lbesson requested a review from brunobesson February 1, 2023 15:53
@lbesson lbesson marked this pull request as ready for review February 1, 2023 15:57
brunobesson
brunobesson approved these changes Feb 3, 2023
View reviewed changes
Copy link
Member

@brunobesson brunobesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I remember well, we handle the case where some formats declared in <picture> tag on the UI side, isn't it? If so, then fine for me.

src/koa/routes.ts Show resolved Hide resolved
@lbesson lbesson merged commit 2e55c1e into main Feb 22, 2023
@lbesson lbesson deleted the issue-173 branch February 22, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brunobesson brunobesson brunobesson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lbesson @brunobesson