Task/ww/avoid-spawnSync #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
making nativeNC working with log using execSync in child process trial to make single client connection working Revert "trial to make single client connection working" This reverts commit d49656f. wip trial to write to buffer Revert "trial to write to buffer" This reverts commit 563ba6e. making writing to file working setting debugMode false clean up minor addressing comments adding random id for response file updating version revert adding id for each response file bump version
avoid json parsing the actual response content fixing error toggle debugMode to false
This reverts commit a88ced4.
This reverts commit 3a6e6a1.
This reverts commit 1c9d690.
c3wenjiaowang
commented
Jun 27, 2023
| // use spawnSync (original sync-rpc method for sending request) for: | ||
| // 1. setup module (.t == 1) | ||
| // 2. normal request (.t == 0) and the request is an api call. (some server api calls fail with writing to keep-alive channel, like Pkg.writeContents.) | ||
| return input.t === 1 || input.t === 0 && input.a.u.indexOf('/typesys/8/') === -1; |
There was a problem hiding this comment.
limit the keep-alive channel to only serve type loading requests (with /typesys/8/ path), as it can't handle large amount of msg written to the channel. In Bundler, we are writing 18 Mb data for Pkg.writeContents call, and it hangs forever.
tonescones
reviewed
Jun 29, 2023
lib/index.js
Outdated
| function readResponseFile(filePath) { | ||
| const startTime = Date.now(); | ||
| while (!responseFileReadyForReading(filePath)) { | ||
| // if (timeLimitExceeded(startTime)) { |
tonescones
approved these changes
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.