change d3 version, so that npm install doesn't install contextify #1457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Duplicate of #1166. |
jasongilman
added a commit
to jasongilman/proto-repl-charts
that referenced
this pull request
Feb 29, 2016
… dependency. See c3js/c3#1457
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contextify, a dependency of jsdom, which in turn has been a dependency of d3 in version 3.5, still gets installed when I go
npm install c3@latest.This breaks c3 if you install it via node4 (because building contextify in node 4 isn't possible right now)
Upgrading to the latest minor version of d3 fixes this, because jsdom has been made a dev dependency rather than a hard dependency.