Fix tooltip randomly switching when have equal values #2311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panthony
force-pushed
the
fix/tooltip-random-order
branch
2 times, most recently
from
4fe652b to
7a52cfd
Compare
panthony
force-pushed
the
fix/tooltip-random-order
branch
from
7a52cfd to
32fe13f
Compare
Codecov Report
@@ Coverage Diff @@
## master #2311 +/- ##
=========================================
+ Coverage 74.95% 75.86% +0.9%
=========================================
Files 51 51
Lines 4233 4235 +2
=========================================
+ Hits 3173 3213 +40
+ Misses 1060 1022 -38
Continue to review full report at Codecov.
|
|
I confirmed this fixes the example of #2293. Thank you for the contribution! (The iteration of sorting and reversing caused the flipping the order of the entries of the same values. This PR removes the reversing of targets and flipping behavior disappears.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue described by #2293 and introduced by #1814.
Hopefully, this time, it does not introduce any more regressions.
There are lot's of tooltip/donut tests around sorting and they are all greens.
close #2293