Fix hovering state when target contains special characters #2315
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PRs fixes the following issue:
CSS class names are NOT allowed spaces but every other characters is fine (https://www.w3.org/TR/CSS21/syndata.html#characters).
Since they are all prefixed by
c3-targets-
we do not have to care about the first character.We simply need to escape in
querySelector
or in CSS if any.I don't know if
c3-target-XXX
is considered public or private api but this PR will break css/js based on this css class when target contains special characters.close #1687