Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for d3.v5 #2335

Merged
merged 3 commits into from
May 14, 2018
Merged

Fix for d3.v5 #2335

merged 3 commits into from
May 14, 2018

Conversation

masayuki0812
Copy link
Member

I checked every sample in htdocs/samples and looks working.

Closes #2319

@kt3k
Copy link
Member

kt3k commented Apr 1, 2018

I agree with this change. Should we bump minor version (+0.1.0) or patch version (+0.0.1) after merging this?

I think we need to update getting started guide's D3 version as well. (That document is now in this repository, migrated from c3js/c3js.org)

@panthony
Copy link
Contributor

panthony commented Apr 1, 2018

D3 5.0 introduces only a few non-backwards-compatible changes.

@kt3k I'd say minor at least... shouldn't introduce breaking changes on a patch version.

@kt3k kt3k added this to the 0.6 milestone Apr 3, 2018
@codecov-io
Copy link

codecov-io commented Apr 21, 2018

Codecov Report

Merging #2335 into master will increase coverage by 0.03%.
The diff coverage is 20%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2335      +/-   ##
==========================================
+ Coverage   77.12%   77.15%   +0.03%     
==========================================
  Files          51       51              
  Lines        4131     4124       -7     
==========================================
- Hits         3186     3182       -4     
+ Misses        945      942       -3
Impacted Files Coverage Δ
src/data.convert.js 88.63% <20%> (+1.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d358f3...7eb4a4b. Read the comment docs.

@kt3k kt3k merged commit 765cc5f into master May 14, 2018
@kt3k kt3k deleted the feature/d3_v5 branch May 14, 2018 13:24
@kt3k
Copy link
Member

kt3k commented May 14, 2018

Released as v0.6.0 https://github.com/c3js/c3/releases/tag/v0.6.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants