Skip to content
This repository has been archived by the owner on Aug 15, 2024. It is now read-only.

fix: fix build script to take env variables into account #120

Merged
merged 1 commit into from
Oct 27, 2023
Merged

fix: fix build script to take env variables into account #120

merged 1 commit into from
Oct 27, 2023

Conversation

PascalinDe
Copy link
Member

@PascalinDe PascalinDe commented Oct 26, 2023 •
edited
Loading

This PR fixes the build script by:

  • incorporating the ANDROID_NDK_HOME env variable that is set in the CI's image and can be set by the user to point to their location
  • if it points to another version, trying whether the required version is installed and using that

@PascalinDe PascalinDe marked this pull request as draft October 26, 2023 15:56
@PascalinDe PascalinDe force-pushed the fix-build branch 3 times, most recently from ce459b2 to 0fdf6de Compare October 27, 2023 12:16
@PascalinDe PascalinDe mentioned this pull request Oct 27, 2023
Merged
ineiti
ineiti approved these changes Oct 27, 2023
View reviewed changes
Copy link
Member

@ineiti ineiti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Some Rust comments.

build.rs Show resolved Hide resolved
build.rs Show resolved Hide resolved
build.rs Show resolved Hide resolved
@PascalinDe PascalinDe marked this pull request as ready for review October 27, 2023 14:47
@PascalinDe PascalinDe merged commit ef21bcf into main Oct 27, 2023
7 checks passed
@PascalinDe PascalinDe deleted the fix-build branch October 27, 2023 14:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ineiti ineiti ineiti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Engineer's TODO
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PascalinDe @ineiti