objectionary#3238 resolved another potions of violations

c71n93 · Aug 6, 2024 · eaf46bb · eaf46bb
1 parent 25f9fe7
commit eaf46bb
Show file tree

Hide file tree

Showing 39 changed files with 139 additions and 56 deletions.
diff --git a/eo-runtime/src/main/java/EOorg/EOeolang/Cages.java b/eo-runtime/src/main/java/EOorg/EOeolang/Cages.java
@@ -24,8 +24,9 @@
 
 /*
  * @checkstyle PackageNameCheck (4 lines)
+ * @checkstyle TrailingCommentCheck (3 lines)
  */
-package EOorg.EOeolang;
+package EOorg.EOeolang; // NOPMD
 
 import java.util.concurrent.ConcurrentHashMap;
 import org.eolang.ExFailure;
@@ -46,13 +47,13 @@ final class Cages {
     /**
      * Encaged objects.
      */
-    private final ConcurrentHashMap<Integer, Phi> objects = new ConcurrentHashMap<>(0);
+    private final ConcurrentHashMap<Integer, Phi> objects;
 
     /**
      * Ctor.
      */
     private Cages() {
-        // singleton :(
+        this.objects = new ConcurrentHashMap<>(0);
     }
 
     /**

diff --git a/eo-runtime/src/main/java/EOorg/EOeolang/EOas_phi.java b/eo-runtime/src/main/java/EOorg/EOeolang/EOas_phi.java
@@ -24,8 +24,9 @@
 
 /*
  * @checkstyle PackageNameCheck (4 lines)
+ * @checkstyle TrailingCommentCheck (3 lines)
  */
-package EOorg.EOeolang;
+package EOorg.EOeolang; // NOPMD
 
 import org.eolang.AtVoid;
 import org.eolang.Atom;
@@ -47,6 +48,7 @@ public final class EOas_phi extends PhDefault implements Atom {
     /**
      * Ctor.
      */
+    @SuppressWarnings("PMD.ConstructorOnlyInitializesOrCallOtherConstructors")
     public EOas_phi() {
         this.add("x", new AtVoid("x"));
     }

diff --git a/eo-runtime/src/main/java/EOorg/EOeolang/EObytes$EOand.java b/eo-runtime/src/main/java/EOorg/EOeolang/EObytes$EOand.java
@@ -24,8 +24,9 @@
 
 /*
  * @checkstyle PackageNameCheck (4 lines)
+ * @checkstyle TrailingCommentCheck (3 lines)
  */
-package EOorg.EOeolang;
+package EOorg.EOeolang; // NOPMD
 
 import org.eolang.AtVoid;
 import org.eolang.Atom;
@@ -45,10 +46,12 @@
  */
 @Versionized
 @XmirObject(oname = "bytes.and")
+@SuppressWarnings("PMD.AvoidDollarSigns")
 public final class EObytes$EOand extends PhDefault implements Atom {
     /**
      * Ctor.
      */
+    @SuppressWarnings("PMD.ConstructorOnlyInitializesOrCallOtherConstructors")
     public EObytes$EOand() {
         this.add("b", new AtVoid("b"));
     }

diff --git a/eo-runtime/src/main/java/EOorg/EOeolang/EObytes$EOconcat.java b/eo-runtime/src/main/java/EOorg/EOeolang/EObytes$EOconcat.java
@@ -24,8 +24,9 @@
 
 /*
  * @checkstyle PackageNameCheck (4 lines)
+ * @checkstyle TrailingCommentCheck (3 lines)
  */
-package EOorg.EOeolang;
+package EOorg.EOeolang; // NOPMD
 
 import org.eolang.AtVoid;
 import org.eolang.Atom;
@@ -45,10 +46,12 @@
  */
 @Versionized
 @XmirObject(oname = "bytes.concat")
+@SuppressWarnings("PMD.AvoidDollarSigns")
 public final class EObytes$EOconcat extends PhDefault implements Atom {
     /**
      * Ctor.
      */
+    @SuppressWarnings("PMD.ConstructorOnlyInitializesOrCallOtherConstructors")
     public EObytes$EOconcat() {
         this.add("b", new AtVoid("b"));
     }

diff --git a/eo-runtime/src/main/java/EOorg/EOeolang/EObytes$EOeq.java b/eo-runtime/src/main/java/EOorg/EOeolang/EObytes$EOeq.java
@@ -24,8 +24,9 @@
 
 /*
  * @checkstyle PackageNameCheck (4 lines)
+ * @checkstyle TrailingCommentCheck (3 lines)
  */
-package EOorg.EOeolang;
+package EOorg.EOeolang; // NOPMD
 
 import java.util.Arrays;
 import org.eolang.AtVoid;
@@ -46,10 +47,12 @@
  */
 @Versionized
 @XmirObject(oname = "bytes.eq")
+@SuppressWarnings("PMD.AvoidDollarSigns")
 public final class EObytes$EOeq extends PhDefault implements Atom {
     /**
      * Ctor.
      */
+    @SuppressWarnings("PMD.ConstructorOnlyInitializesOrCallOtherConstructors")
     public EObytes$EOeq() {
         this.add("b", new AtVoid("b"));
     }

diff --git a/eo-runtime/src/main/java/EOorg/EOeolang/EObytes$EOor.java b/eo-runtime/src/main/java/EOorg/EOeolang/EObytes$EOor.java
@@ -24,8 +24,9 @@
 
 /*
  * @checkstyle PackageNameCheck (4 lines)
+ * @checkstyle TrailingCommentCheck (3 lines)
  */
-package EOorg.EOeolang;
+package EOorg.EOeolang; // NOPMD
 
 import org.eolang.AtVoid;
 import org.eolang.Atom;
@@ -45,10 +46,12 @@
  */
 @Versionized
 @XmirObject(oname = "bytes.or")
+@SuppressWarnings("PMD.AvoidDollarSigns")
 public final class EObytes$EOor extends PhDefault implements Atom {
     /**
      * Ctor.
      */
+    @SuppressWarnings("PMD.ConstructorOnlyInitializesOrCallOtherConstructors")
     public EObytes$EOor() {
         this.add("b", new AtVoid("b"));
     }

diff --git a/eo-runtime/src/main/java/EOorg/EOeolang/EObytes$EOright.java b/eo-runtime/src/main/java/EOorg/EOeolang/EObytes$EOright.java
@@ -24,8 +24,9 @@
 
 /*
  * @checkstyle PackageNameCheck (4 lines)
+ * @checkstyle TrailingCommentCheck (3 lines)
  */
-package EOorg.EOeolang;
+package EOorg.EOeolang; // NOPMD
 
 import org.eolang.AtVoid;
 import org.eolang.Atom;
@@ -45,10 +46,12 @@
  */
 @Versionized
 @XmirObject(oname = "bytes.right")
+@SuppressWarnings("PMD.AvoidDollarSigns")
 public final class EObytes$EOright extends PhDefault implements Atom {
     /**
      * Ctor.
      */
+    @SuppressWarnings("PMD.ConstructorOnlyInitializesOrCallOtherConstructors")
     public EObytes$EOright() {
         this.add("x", new AtVoid("x"));
     }

diff --git a/eo-runtime/src/main/java/EOorg/EOeolang/EObytes$EOsize.java b/eo-runtime/src/main/java/EOorg/EOeolang/EObytes$EOsize.java
@@ -24,8 +24,9 @@
 
 /*
  * @checkstyle PackageNameCheck (4 lines)
+ * @checkstyle TrailingCommentCheck (3 lines)
  */
-package EOorg.EOeolang;
+package EOorg.EOeolang; // NOPMD
 
 import org.eolang.Atom;
 import org.eolang.Attr;
@@ -44,6 +45,7 @@
  */
 @Versionized
 @XmirObject(oname = "bytes.size")
+@SuppressWarnings("PMD.AvoidDollarSigns")
 public final class EObytes$EOsize extends PhDefault implements Atom {
     @Override
     public Phi lambda() {

diff --git a/eo-runtime/src/main/java/EOorg/EOeolang/EObytes$EOslice.java b/eo-runtime/src/main/java/EOorg/EOeolang/EObytes$EOslice.java
@@ -24,8 +24,9 @@
 
 /*
  * @checkstyle PackageNameCheck (4 lines)
+ * @checkstyle TrailingCommentCheck (3 lines)
  */
-package EOorg.EOeolang;
+package EOorg.EOeolang; // NOPMD
 
 import java.util.Arrays;
 import org.eolang.AtVoid;
@@ -46,10 +47,12 @@
  */
 @Versionized
 @XmirObject(oname = "bytes.slice")
+@SuppressWarnings("PMD.AvoidDollarSigns")
 public final class EObytes$EOslice extends PhDefault implements Atom {
     /**
      * Ctor.
      */
+    @SuppressWarnings("PMD.ConstructorOnlyInitializesOrCallOtherConstructors")
     public EObytes$EOslice() {
         this.add("start", new AtVoid("start"));
         this.add("len", new AtVoid("len"));

diff --git a/eo-runtime/src/main/java/EOorg/EOeolang/EObytes$EOxor.java b/eo-runtime/src/main/java/EOorg/EOeolang/EObytes$EOxor.java
@@ -24,8 +24,9 @@
 
 /*
  * @checkstyle PackageNameCheck (4 lines)
+ * @checkstyle TrailingCommentCheck (3 lines)
  */
-package EOorg.EOeolang;
+package EOorg.EOeolang; // NOPMD
 
 import org.eolang.AtVoid;
 import org.eolang.Atom;
@@ -45,10 +46,12 @@
  */
 @Versionized
 @XmirObject(oname = "bytes.xor")
+@SuppressWarnings("PMD.AvoidDollarSigns")
 public final class EObytes$EOxor extends PhDefault implements Atom {
     /**
      * Ctor.
      */
+    @SuppressWarnings("PMD.ConstructorOnlyInitializesOrCallOtherConstructors")
     public EObytes$EOxor() {
         this.add("b", new AtVoid("b"));
     }

diff --git a/eo-runtime/src/main/java/EOorg/EOeolang/EOcage$EOencaged$EOencage.java b/eo-runtime/src/main/java/EOorg/EOeolang/EOcage$EOencaged$EOencage.java
@@ -24,8 +24,9 @@
 
 /*
  * @checkstyle PackageNameCheck (4 lines)
+ * @checkstyle TrailingCommentCheck (3 lines)
  */
-package EOorg.EOeolang;
+package EOorg.EOeolang; // NOPMD
 
 import org.eolang.AtVoid;
 import org.eolang.Atom;
@@ -44,10 +45,12 @@
  */
 @Versionized
 @XmirObject(oname = "cage.encaged.encage")
+@SuppressWarnings("PMD.AvoidDollarSigns")
 public final class EOcage$EOencaged$EOencage extends PhDefault implements Atom {
     /**
      * Ctor.
      */
+    @SuppressWarnings("PMD.ConstructorOnlyInitializesOrCallOtherConstructors")
     EOcage$EOencaged$EOencage() {
         this.add("object", new AtVoid("object"));
     }

diff --git a/eo-runtime/src/main/java/EOorg/EOeolang/EOcage$EOφ.java b/eo-runtime/src/main/java/EOorg/EOeolang/EOcage$EOφ.java
@@ -24,8 +24,9 @@
 
 /*
  * @checkstyle PackageNameCheck (4 lines)
+ * @checkstyle TrailingCommentCheck (3 lines)
  */
-package EOorg.EOeolang;
+package EOorg.EOeolang; // NOPMD
 
 import org.eolang.Atom;
 import org.eolang.Attr;
@@ -42,6 +43,7 @@
  */
 @Versionized
 @XmirObject(oname = "cage.@")
+@SuppressWarnings("PMD.AvoidDollarSigns")
 public final class EOcage$EOφ extends PhDefault implements Atom {
     @Override
     public Phi lambda() throws Exception {

diff --git a/eo-runtime/src/main/java/EOorg/EOeolang/EOdataized.java b/eo-runtime/src/main/java/EOorg/EOeolang/EOdataized.java
@@ -24,8 +24,9 @@
 
 /*
  * @checkstyle PackageNameCheck (4 lines)
+ * @checkstyle TrailingCommentCheck (3 lines)
  */
-package EOorg.EOeolang;
+package EOorg.EOeolang; // NOPMD
 
 import org.eolang.AtVoid;
 import org.eolang.Atom;
@@ -46,6 +47,7 @@ public final class EOdataized extends PhDefault implements Atom {
     /**
      * Ctor.
      */
+    @SuppressWarnings("PMD.ConstructorOnlyInitializesOrCallOtherConstructors")
     public EOdataized() {
         this.add("target", new AtVoid("target"));
     }

diff --git a/eo-runtime/src/main/java/EOorg/EOeolang/EOfs/EOdir$EOmade$EOmkdir.java b/eo-runtime/src/main/java/EOorg/EOeolang/EOfs/EOdir$EOmade$EOmkdir.java
@@ -24,8 +24,9 @@
 
 /*
  * @checkstyle PackageNameCheck (4 lines)
+ * @checkstyle TrailingCommentCheck (3 lines)
  */
-package EOorg.EOeolang.EOfs;
+package EOorg.EOeolang.EOfs; // NOPMD
 
 import java.nio.file.Paths;
 import org.eolang.Atom;
@@ -43,6 +44,7 @@
  * @checkstyle TypeNameCheck (100 lines)
  */
 @XmirObject(oname = "dir.made.mkdir")
+@SuppressWarnings("PMD.AvoidDollarSigns")
 public final class EOdir$EOmade$EOmkdir extends PhDefault implements Atom {
     @Override
     public Phi lambda() throws Exception {

diff --git a/eo-runtime/src/main/java/EOorg/EOeolang/EOfs/EOdir$EOtmpfile$EOtouch.java b/eo-runtime/src/main/java/EOorg/EOeolang/EOfs/EOdir$EOtmpfile$EOtouch.java
@@ -24,8 +24,9 @@
 
 /*
  * @checkstyle PackageNameCheck (4 lines)
+ * @checkstyle TrailingCommentCheck (3 lines)
  */
-package EOorg.EOeolang.EOfs;
+package EOorg.EOeolang.EOfs; // NOPMD
 
 import java.nio.file.Files;
 import java.nio.file.Path;
@@ -45,6 +46,7 @@
  * @checkstyle TypeNameCheck (100 lines)
  */
 @XmirObject(oname = "dir.tmpfile.touch")
+@SuppressWarnings("PMD.AvoidDollarSigns")
 public final class EOdir$EOtmpfile$EOtouch extends PhDefault implements Atom {
     @Override
     public Phi lambda() throws Exception {

diff --git a/eo-runtime/src/main/java/EOorg/EOeolang/EOfs/EOfile$EOexists.java b/eo-runtime/src/main/java/EOorg/EOeolang/EOfs/EOfile$EOexists.java
@@ -24,8 +24,9 @@
 
 /*
  * @checkstyle PackageNameCheck (4 lines)
+ * @checkstyle TrailingCommentCheck (3 lines)
  */
-package EOorg.EOeolang.EOfs;
+package EOorg.EOeolang.EOfs; // NOPMD
 
 import java.nio.file.Files;
 import java.nio.file.Paths;
@@ -44,6 +45,7 @@
  * @checkstyle TypeNameCheck (100 lines)
  */
 @XmirObject(oname = "file.exists")
+@SuppressWarnings("PMD.AvoidDollarSigns")
 public final class EOfile$EOexists extends PhDefault implements Atom {
     @Override
     public Phi lambda() throws Exception {

diff --git a/eo-runtime/src/main/java/EOorg/EOeolang/EOfs/EOfile$EOmoved$EOmove.java b/eo-runtime/src/main/java/EOorg/EOeolang/EOfs/EOfile$EOmoved$EOmove.java
@@ -24,8 +24,9 @@
 
 /*
  * @checkstyle PackageNameCheck (4 lines)
+ * @checkstyle TrailingCommentCheck (3 lines)
  */
-package EOorg.EOeolang.EOfs;
+package EOorg.EOeolang.EOfs; // NOPMD
 
 import java.nio.file.Files;
 import java.nio.file.Path;
@@ -45,6 +46,7 @@
  * @checkstyle TypeNameCheck (100 lines)
  */
 @XmirObject(oname = "file.moved.move")
+@SuppressWarnings("PMD.AvoidDollarSigns")
 public final class EOfile$EOmoved$EOmove extends PhDefault implements Atom {
     @Override
     public Phi lambda() throws Exception {

diff --git a/...rc/main/java/EOorg/EOeolang/EOfs/EOfile$EOopen$EOfile_stream$EOwrite$EOwritten_bytes.java b/...rc/main/java/EOorg/EOeolang/EOfs/EOfile$EOopen$EOfile_stream$EOwrite$EOwritten_bytes.java
@@ -24,8 +24,9 @@
 
 /*
  * @checkstyle PackageNameCheck (4 lines)
+ * @checkstyle TrailingCommentCheck (3 lines)
  */
-package EOorg.EOeolang.EOfs;
+package EOorg.EOeolang.EOfs; // NOPMD
 
 import java.nio.file.Paths;
 import org.eolang.AtVoid;
@@ -44,13 +45,15 @@
  * @checkstyle TypeNameCheck (100 lines)
  */
 @XmirObject(oname = "file.open.file-stream.write.written-bytes")
+@SuppressWarnings("PMD.AvoidDollarSigns")
 public final class EOfile$EOopen$EOfile_stream$EOwrite$EOwritten_bytes
     extends PhDefault
     implements Atom {
 
     /**
      * Ctor.
      */
+    @SuppressWarnings("PMD.ConstructorOnlyInitializesOrCallOtherConstructors")
     public EOfile$EOopen$EOfile_stream$EOwrite$EOwritten_bytes() {
         this.add("buffer", new AtVoid("buffer"));
     }