Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: [bitget] get account assets #1456

Merged
merged 3 commits into from
Jan 3, 2024

Conversation

bailantaotao
Copy link
Collaborator

There are too many unheld coins in the v1 returned assets, making it difficult to filter them out. Therefore, I am using the v2 API to address this issue.

@bbgokarma-bot
Copy link

Welcome back! @bailantaotao, This pull request may get 472 BBG.

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 477 BBG

Copy link

codecov bot commented Dec 18, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (0466165) 21.32% compared to head (b5ff066) 21.28%.
Report is 72 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1456      +/-   ##
==========================================
- Coverage   21.32%   21.28%   -0.05%     
==========================================
  Files         590      596       +6     
  Lines       43434    43933     +499     
==========================================
+ Hits         9262     9349      +87     
- Misses      33497    33907     +410     
- Partials      675      677       +2     
Files Coverage Δ
pkg/exchange/bitget/convert.go 91.73% <100.00%> (ø)
.../bitget/bitgetapi/v2/get_account_assets_request.go 0.00% <0.00%> (ø)
pkg/exchange/bitget/exchange.go 0.00% <0.00%> (-0.79%) ⬇️

... and 24 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0466165...b5ff066. Read the comment docs.

client requestgen.AuthenticatedAPIClient

coin *string `param:"symbol,query"`
assetType AssetType `param:"limit,query"`
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

name is assetType but key=limit?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fire eye bling bling

@bailantaotao bailantaotao force-pushed the edwin/bitget/get-account-assets branch from 141d7ed to 30164ac Compare January 3, 2024 03:26
@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 507 BBG

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 512 BBG

@bailantaotao bailantaotao merged commit 769d3ce into main Jan 3, 2024
3 of 4 checks passed
@bailantaotao bailantaotao deleted the edwin/bitget/get-account-assets branch January 3, 2024 05:01
@bbgokarma-bot
Copy link

Hi @bailantaotao,

Well done! 517 BBG has been sent to your polygon wallet. Please check the following tx:

https://polygonscan.com/tx/0xe7192fd9c28b3747ea12b9c6eea920b082117d83d8a32f7420ab9fdb3fed9639

Thank you for your contribution!

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants