Selected genes list populates when there is only one group selected

[jfkonecn]

Fix cBioPortal/cbioportal#10088

Describe changes proposed in this pull request:

• There was a guard in the makeEnrichmentDataPromise function that was preventing the gene list from being populated

Why no test?
This is a network request based issue so it'll be difficult to create a non-brittle test

Checks

• Has tests or has a separate issue that describes the types of test that should be created. If no test is included it should explicitly be mentioned in the PR why there is no test.
• The commit log is comprehensible. It follows 7 rules of great commit messages. For most PRs a single commit should suffice, in some cases multiple topical commits can be useful. During review it is ok to see tiny commits (e.g. Fix reviewer comments), but right before the code gets merged to master or rc branch, any such commits should be squashed since they are useless to the other developers. Definitely avoid merge commits, use rebase instead.
• Is this PR adding logic based on one or more clinical attributes? If yes, please make sure validation for this attribute is also present in the data validation / data loading layers (in backend repo) and documented in File-Formats Clinical data section!

@alisman @onursumer

[onursumer]

Maybe simplify it this way?

Suggested change

	(this.alterationsEnrichmentDataRequestGroups.result &&
	this.alterationsEnrichmentDataRequestGroups.result.length >
	this.alterationsEnrichmentDataRequestGroups.result?.length

Technically, we don't even need the check > 0.

[jfkonecn]

Personally I prefer to have the > 0 since it's more explicit, but I'm happy to change it if you want me to.

[onursumer]

We can keep the > 0. I don't have a strong preference.

[onursumer]

Ah, just realized if we keep the > 0 then the above simplification doesn't work. TypeScript complains if we do

this.alterationsEnrichmentDataRequestGroups.result?.length > 0

[onursumer]

Sorry for dragging this out but if we really want to be explicit we can also do this:

!_.isEmpty(this.alterationsEnrichmentDataRequestGroups.result)

[jfkonecn]

No worries I can do that