Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed png download for group comparison clinical data #4888

Merged
merged 2 commits into from
Apr 15, 2024

Conversation

khaledfahmy123
Copy link
Contributor

@khaledfahmy123 khaledfahmy123 commented Apr 9, 2024

Fix cBioPortal/cbioportal#10742

Describe changes proposed in this pull request:

  • the problem arises from referencing external css styling from the svg element
  • i made some css inlining using juice

Any screenshots or GIFs?

Before

before_png_bug_2.mp4

After

45879ab7-f04c-4c30-a269-80c6572bdb22.mp4

Notify reviewers

@inodb

Copy link

netlify bot commented Apr 9, 2024

Deploy Preview for cbioportalfrontend ready!

Name Link
🔨 Latest commit cd2f448
🔍 Latest deploy log https://app.netlify.com/sites/cbioportalfrontend/deploys/6615c1295bd5380008da8782
😎 Deploy Preview https://deploy-preview-4888--cbioportalfrontend.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

);

// parsing as SVGElement after css inlining
let parser = new DOMParser();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how come we have to parse it back to SVG? is it just because saveMethod takes SVG?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah exactly juice returns a string containing inlined html and saveMethod takes only SVGElement

@inodb inodb merged commit f87c744 into cBioPortal:master Apr 15, 2024
12 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

png download is broken for group comparison clinical data
3 participants