Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move 'juice' inside cbioportal-frontend-commons #4936

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Move 'juice' inside cbioportal-frontend-commons #4936

merged 1 commit into from
Jul 3, 2024

Conversation

leexgh
Copy link
Member

@leexgh leexgh commented Jul 2, 2024 •
edited by onursumer
Loading

Fix: cBioPortal/cbioportal#10878
juice is used only in cbioportal-frontend-commons (see link), we need to add juice in the cbioportal-frontend-commons and remove from main package.json

@netlify Netlify
Copy link

netlify bot commented Jul 2, 2024 •
edited
Loading

✅ Deploy Preview for cbioportalfrontend ready!

Name Link
🔨 Latest commit 026142e
🔍 Latest deploy log https://app.netlify.com/sites/cbioportalfrontend/deploys/6684755cc8b631000890aed1
😎 Deploy Preview https://deploy-preview-4936--cbioportalfrontend.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@leexgh leexgh added dependencies Pull requests that update a dependency file bug labels Jul 2, 2024
@leexgh leexgh requested a review from onursumer July 2, 2024 19:32
onursumer
onursumer requested changes Jul 2, 2024
View reviewed changes
Copy link
Member

@onursumer onursumer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't need to manually change the library version. publish bot will handle versioning.

package.json Outdated Show resolved Hide resolved
packages/cbioportal-clinical-timeline/package.json Outdated Show resolved Hide resolved
packages/cbioportal-frontend-commons/package.json Outdated Show resolved Hide resolved
packages/react-mutation-mapper/package.json Outdated Show resolved Hide resolved
packages/react-variant-view/package.json Outdated Show resolved Hide resolved
@leexgh leexgh requested a review from onursumer July 2, 2024 21:47
@leexgh leexgh changed the title Move 'juice' inside cbioportal-frontend-commons' and update to beta version Move 'juice' inside cbioportal-frontend-commons Jul 3, 2024
@onursumer onursumer merged commit 12e9b13 into cBioPortal:master Jul 3, 2024
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onursumer onursumer onursumer approved these changes

Assignees
No one assigned
Labels
bug dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

0.5.66 cbioportal-frontend-commons missing 'juice' module
2 participants
@leexgh @onursumer