Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use proxy to fetch news #4941

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

onursumer
Copy link
Member

Seems like Github pages now allow CORS. We don't need to use the proxy to fetch news content.

@onursumer onursumer requested review from alisman and inodb July 9, 2024 21:30
Copy link

netlify bot commented Jul 9, 2024

Deploy Preview for cbioportalfrontend ready!

Name Link
🔨 Latest commit e9eb571
🔍 Latest deploy log https://app.netlify.com/sites/cbioportalfrontend/deploys/668dabffa5bdc60008d06d73
😎 Deploy Preview https://deploy-preview-4941--cbioportalfrontend.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@alisman alisman merged commit a9531ef into cBioPortal:master Jul 11, 2024
11 of 15 checks passed
@dippindots dippindots added the chore This PR is related to code maintenance label Jul 16, 2024
@onursumer onursumer deleted the do-not-use-proxy-for-news branch August 22, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore This PR is related to code maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants