fix localStorage.frontendConfig being clobbered when localhost:3000 testing #4955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cbioportalfrontend ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
alisman
approved these changes
Aug 12, 2024
Nelliney
pushed a commit
to Nelliney/cbioportal-frontend
that referenced
this pull request
Aug 14, 2024
…esting (cBioPortal#4955) Co-authored-by: Denis Papp <pappde@users.noreply.github.com>
Nelliney
pushed a commit
to Nelliney/cbioportal-frontend
that referenced
this pull request
Aug 14, 2024
…esting (cBioPortal#4955) Co-authored-by: Denis Papp <pappde@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Fixed
When testing with localhost:3000, if you are manually setting "localStorage.frontendConfig" via the browser console, it gets clobbered by some test code in my-index.ejs.
Change
Removed (commented out) the test code.
Notify reviewers
@alisman