Add Histogram Zoom Preview on Study View #4957
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cbioportalfrontend ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
olzhasmukayev
force-pushed
the
feat/bar-chart-preview
branch
from
821508f
to
7b990ad
Compare
gblaih
reviewed
Aug 8, 2024
| <FlexAlignedCheckbox | ||
| checked={ | ||
| !!( | ||
| this.props.chartControls && |
There was a problem hiding this comment.
simplify to !!this.props.chartControls?.showPreview
gblaih
reviewed
Aug 8, 2024
Comment on lines
630
to
639
| if (this._customDataBinFilterSet.has(uniqueKey)) { | ||
| const filter = this._customDataBinFilterSet.get(uniqueKey); | ||
| return filter === undefined | ||
| ? false | ||
| : (filter!.showPreview as boolean); | ||
| } else { | ||
| const filter = this.getDataBinFilterSet(uniqueKey).get(uniqueKey)!; | ||
| return filter?.showPreview === undefined | ||
| ? false | ||
| : (filter!.showPreview as boolean); |
There was a problem hiding this comment.
i think this could be simplified. one way could be to use ternary operator (n ? x : y) to get the filter and something like return filter?.showPreview || false for the return value
gblaih
reviewed
Aug 8, 2024
| @@ -74,7 +84,37 @@ export default class BarChart extends React.Component<IBarChartProps, {}> | |||
|
|
|||
| constructor(props: IBarChartProps) { | |||
| super(props); | |||
| this.state = { | |||
There was a problem hiding this comment.
we mainly use mobx for state management so instead of this.state and setState we use decorators like @observable and @action. can we look into this and see if we can do that?
gblaih
reviewed
Aug 8, 2024
Comment on lines
102
to
111
| if (!domain || !domain.x) { | ||
| console.error('Brush domain is not defined.'); | ||
| return; | ||
| } |
There was a problem hiding this comment.
lets remove this and just check if domain and domain.x are defined and if so do the actions below.
inodb
changed the title
olzhasmukayev
force-pushed
the
feat/bar-chart-preview
branch
from
7b990ad
to
d48bfc7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Histogram Zoom Preview:
