Fix plots tab related data loading on initial study view load #4958
+19
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cbioportalfrontend ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
alisman
reviewed
Aug 13, 2024
| @@ -3750,7 +3754,7 @@ export default class PlotsTab extends React.Component<IPlotsTabProps, {}> { | |||
| options = options.filter(stringCompare).slice(0, 10); | |||
| const genes = await fetchGenes(options.map(o => o.label)); | |||
| const coverageInformationPromise = getCoverageInformation( | |||
| this.props.genePanelDataForAllProfiles!, | |||
| this.props.genePanelDataForAllProfiles?.result || [], | |||
There was a problem hiding this comment.
can we make sure that we're awaiting result properly and then use ! to assert it isntead of ?. in other words, using ? implies that we aren't sure it's loaded yet, and we should be sure.
alisman
reviewed
Aug 13, 2024
| this.props.hugoGeneSymbols, | ||
| Array.isArray(this.props.hugoGeneSymbols) | ||
| ? this.props.hugoGeneSymbols | ||
| : this.props.hugoGeneSymbols.result, |
There was a problem hiding this comment.
seems strange. i guess this is due to fact that it's used differently in different places. but there should be a better way to handle this.
alisman
requested changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix cBioPortal/cbioportal#10897