Modify fetch resources from single study to multi-study #5038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cbioportalfrontend ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
alisman
reviewed
Nov 4, 2024
| projection: 'DETAILED', | ||
| } | ||
| // Fetch resource data for each studyId, then return combined results | ||
| const allResources = _(studyIds) |
There was a problem hiding this comment.
the js array natively has map on it so you don't need to wrap in lodash here. this might seem confusing given what i said last week but the real message is that we should strive to use the semantically accurate and descriptive method. if it's just map, then no reason to use lodash. the other reason to use lodash is it's support for chaining, but we're not doing that here.
There was a problem hiding this comment.
Okay no problem I can change to the native map. I was just going off of what the previous author did in another function in this same file.
alisman
approved these changes
Nov 4, 2024
alisman
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix cBioPortal/cbioportal#11158. Add multiy-study result for files & resource tab on Study view. Fetch resource data for each study on the frontend and combine the results. Note: in the future we might want to improve the endpoint to handle multiple studies directly