Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add retry logic for 404 errors #5040

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Conversation

zainasir
Copy link
Member

@zainasir zainasir commented Nov 6, 2024

Fix cBioPortal/cbioportal# (see https://help.github.com/en/articles/closing-issues-using-keywords)

Describe changes proposed in this pull request:

  • Modified github action "Trigger JitPack Build". Now, the action keeps retriggering the jitpack build every 30 seconds for a maximum of 5 minutes, until the jitpack url returns a success code of 200.

Checks

  • Has tests or has a separate issue that describes the types of test that should be created. If no test is included it should explicitly be mentioned in the PR why there is no test.
  • The commit log is comprehensible. It follows 7 rules of great commit messages. For most PRs a single commit should suffice, in some cases multiple topical commits can be useful. During review it is ok to see tiny commits (e.g. Fix reviewer comments), but right before the code gets merged to master or rc branch, any such commits should be squashed since they are useless to the other developers. Definitely avoid merge commits, use rebase instead.
  • Is this PR adding logic based on one or more clinical attributes? If yes, please make sure validation for this attribute is also present in the data validation / data loading layers (in backend repo) and documented in File-Formats Clinical data section!

Any screenshots or GIFs?

If this is a new visual feature please add a before/after screenshot or gif
here with e.g. Giphy CAPTURE or Peek

Notify reviewers

Read our Pull request merging
policy
. It can help to figure out who worked on the
file before you. Please use git blame <filename> to determine that
and notify them either through slack or by assigning them as a reviewer on the PR

Copy link

netlify bot commented Nov 6, 2024

Deploy Preview for cbioportalfrontend ready!

Name Link
🔨 Latest commit 3dff871
🔍 Latest deploy log https://app.netlify.com/sites/cbioportalfrontend/deploys/672be28bf01ffe00086531ca
😎 Deploy Preview https://deploy-preview-5040.cancerrevue.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@zainasir zainasir added the devops label Nov 6, 2024
Copy link
Member

@dippindots dippindots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice fix, thanks!

@zainasir zainasir merged commit 9a8511a into cBioPortal:master Nov 6, 2024
5 of 7 checks passed
@zainasir zainasir deleted the jitpack-action branch November 6, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants