Paginated clinical table #10211
Merged
Paginated clinical table #10211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BasLee
changed the title
|
@BasLee Is this error in the automated tests, something that is of concern? |
@JREastonMarks Seemed to be a difference between mysql and h2 db used in tests. Fixed in 5ba9828 |
dippindots
reviewed
Jun 13, 2023
There was a problem hiding this comment.
@BasLee It looks good to me, I think if you rebase your pr, the core tests will pass. I have few minor comments.
...istence/persistence-api/src/main/java/org/cbioportal/persistence/ClinicalDataRepository.java
Outdated
Show resolved
Hide resolved
...istence/persistence-api/src/main/java/org/cbioportal/persistence/ClinicalDataRepository.java
Outdated
Show resolved
Hide resolved
...istence-mybatis/src/main/resources/org/cbioportal/persistence/mybatis/ClinicalDataMapper.xml
Show resolved
Hide resolved
added 9 commits
June 14, 2023 14:42
BasLee
force-pushed
the
poc-paginated-clinical-table
branch
from
5ba9828
to
9d7c2b3
Compare
BasLee
force-pushed
the
poc-paginated-clinical-table
branch
from
18626e2
to
654a5d6
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Paginate the clinical table using original (lazy mobx) table components.
The backend
/clinical-data-table/fetchalready contained most elements needed for pagination, like page size and page number. This PR also adds a header containing the total number of samples, needed for pagination in the frontend.To be able to sort properly, the sortBy parameter also had to be modified.
See frontend PR for more information.
Changes
total-countresponse header to/clinical-data-table/fetchgetSampleClinicalDataClinicalTablequery and new count query