Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve validation of Entity Stable ID #10365

Merged
merged 2 commits into from
Sep 7, 2023
Merged

Conversation

oplantalech
Copy link
Contributor

The Generic Assay's Entity Stable IDs was only validated for containing spaces. This PR improves its validation by not enabling Entity Stable IDs for containing other characters rather than alphanumeric, dots, underscores or dashes - like all other cBioPortal IDs.

@dippindots dippindots force-pushed the fix_generic_entity_id branch from 3f60b41 to 1d8227b Compare September 6, 2023 10:33
@sonarcloud
Copy link

sonarcloud bot commented Sep 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@rmadupuri rmadupuri merged commit 5315006 into master Sep 7, 2023
14 checks passed
@rmadupuri rmadupuri deleted the fix_generic_entity_id branch September 7, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants