Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Label checker action reruns when needed #10462

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Label checker action reruns when needed #10462

merged 1 commit into from
Nov 9, 2023

Conversation

Luke-Sikina
Copy link
Member

  • The label checker GH action currently runs when a PR is posted, but not when labels are added
  • Since most people add labels after they post a PR, this makes the action mostly useless
  • Fix: rerun action on add/remove label
  • If this works, you could start making label checker a required check, which would make your release process a little cleaner, I think

@Luke-Sikina Luke-Sikina added the bug label Nov 9, 2023
Label checker action reruns when needed
f4618c8 
- The label checker GH action currently runs when a PR is posted,
but not when labels are added
- Since most people add labels _after_ they post a PR, this makes the
action mostly useless
- Fix: rerun action on add/remove label
- If this works, you could start making label checker a required check,
which would make your release process a little cleaner
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

inodb
inodb approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@inodb inodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks @Luke-Sikina !

@inodb inodb merged commit 27efb16 into cBioPortal:master Nov 9, 2023
17 of 18 checks passed
@inodb inodb added devops and removed bug labels Nov 14, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inodb inodb inodb approved these changes

@alisman alisman Awaiting requested review from alisman

Assignees
No one assigned
Labels
devops
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Luke-Sikina @inodb