-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable multi-study study-view cache #10764
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Let's wait for Aaron to look this over. We should also monitor the redis cache when we deploy this (how much does this increase the memory footprint? How often are we clearing existing keys etc) |
@kalletlak @jjgao @inodb i think we limited it to single study queries because we worried about permutations of studies overwhelming cache. probably should have tried it first to see if there was a problem. anyway, we can merge this but we should perhaps monitor the cache for the public portal to see if this changes things dramatically |
Fix #10746