Implement molecular-profile-sample-counts endpoint #10798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alisman
force-pushed
the
demo-rfc80-poc
branch
4 times, most recently
from
fa6c559
to
2f71790
Compare
alisman
commented
May 17, 2024
| import org.cbioportal.model.ClinicalData; | ||
| import org.cbioportal.model.ClinicalDataCount; | ||
| import org.cbioportal.model.Sample; | ||
| import org.cbioportal.model.*; |
There was a problem hiding this comment.
i think IDE did this. what's right?
There was a problem hiding this comment.
Do you need help with your ide settings?
haynescd
requested changes
May 17, 2024
| @Override | ||
| public List<GenomicDataCount> getGenomicDataCounts(StudyViewFilter studyViewFilter, CategorizedClinicalDataCountFilter categorizedClinicalDataCountFilter) { | ||
|
|
||
| //return new ArrayList<GenomicDataCount>(); |
|
|
||
| <!-- for /molecular-profile-sample-counts/fetch (returns GenomicDataCount) --> | ||
| <select id="getGenomicDataCounts" resultType="org.cbioportal.model.GenomicDataCount"> | ||
| SELECT genetic_profile.stable_id AS value, genetic_profile.stable_id AS value2, genetic_profile.name AS label, count(sample_profile.genetic_profile_id) AS count FROM sample_profile |
There was a problem hiding this comment.
Can we have each column on a new line? (just easier to read)
Ex.
Select
stable_id,
name
alisman
commented
May 20, 2024
| @@ -13,6 +13,26 @@ | |||
| #{studyId} | |||
| </foreach> | |||
| </if> | |||
|
|
|||
|
|
|||
| <if test="studyViewFilter.genomicProfiles != null and !studyViewFilter.genomicProfiles.isEmpty()"> | |||
There was a problem hiding this comment.
@gblaih here is the filter. i found a small problem with foreach at the bottom but this is the basic idea.
alisman
force-pushed
the
demo-rfc80-poc
branch
2 times, most recently
from
f744d2e
to
c6b9031
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.