Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update documentation on test logging #9909

Merged
merged 1 commit into from
Feb 27, 2023
Merged

Update documentation on test logging #9909

merged 1 commit into from
Feb 27, 2023

Conversation

BasLee
Copy link

@BasLee BasLee commented Nov 28, 2022

Add some documentation on how to configure logging during tests.

@sonarcloud
Copy link

sonarcloud bot commented Nov 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Luke-Sikina
Luke-Sikina reviewed Dec 13, 2022
View reviewed changes
Copy link
Member

@Luke-Sikina Luke-Sikina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is correct; we should be using logback for our test logging now. Can you rebase this PR and try following the instructions to see if you can configure test output using slf4j.SimpleLogger? I would expect there to be no change in log output.

pvannierop
pvannierop requested changes Jan 16, 2023
View reviewed changes
Copy link
Contributor

@pvannierop pvannierop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update after merge of PR #9949 that will implement logback logging for all Maven modules.

@sonarcloud
Copy link

sonarcloud bot commented Feb 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@cBioPortal cBioPortal deleted a comment from pvannierop Feb 23, 2023
@inodb inodb merged commit c13bbe8 into cBioPortal:master Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Luke-Sikina Luke-Sikina Luke-Sikina left review comments

@inodb inodb Awaiting requested review from inodb

@pvannierop pvannierop Awaiting requested review from pvannierop

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BasLee @pvannierop @Luke-Sikina @inodb