Return DisconnectReason in the DisconnectEvent for clients #416
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the user has no way of accessing the reason why the connection was not successful (or the reason they got disconnected). There are usually some
error!
logs printed, but the user might need to access the value to handle it in some ad-hoc way.In this PR, we add:
ClientConnection.state()
now returns aConnectionState
instead of aNetworkingState
(- I also add a NetworkingState::None enum to avoid running the OnDisconnect schedule at the start of the app)
Addresses part of #410 (comment)