Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build packet when we cannot write the channel_id #458

Merged
merged 2 commits into from
Jun 5, 2024

Conversation

cBournhonesque
Copy link
Owner

Fixes #455

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.31%. Comparing base (452a02a) to head (fb2c6c8).

Current head fb2c6c8 differs from pull request most recent head 212b8d6

Please upload reports for the commit 212b8d6 to get more accurate results.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #458      +/-   ##
==========================================
- Coverage   70.39%   70.31%   -0.09%     
==========================================
  Files         137      137              
  Lines        9599     9603       +4     
==========================================
- Hits         6757     6752       -5     
- Misses       2842     2851       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cBournhonesque cBournhonesque merged commit e83de1d into main Jun 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash in build_packets
2 participants