Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Local client not sending Connect event in HostServer Mode + Added Test #578

Merged
merged 11 commits into from
Aug 11, 2024

Conversation

zwazel
Copy link
Contributor

@zwazel zwazel commented Aug 10, 2024

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Aug 10, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.31%. Comparing base (0316042) to head (1300d1c).
Report is 29 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #578      +/-   ##
==========================================
+ Coverage   71.69%   72.31%   +0.62%     
==========================================
  Files         144      144              
  Lines        9725     9904     +179     
==========================================
+ Hits         6972     7162     +190     
+ Misses       2753     2742      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@cBournhonesque cBournhonesque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one comment but other this LGTM; thanks!

@cBournhonesque cBournhonesque merged commit c449505 into cBournhonesque:main Aug 11, 2024
4 of 5 checks passed
@cBournhonesque
Copy link
Owner

Thanks, great addition :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants