Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resource replication in host-server mode #592

Merged
merged 1 commit into from
Aug 14, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lightyear/src/client/connection.rs
Original file line number Diff line number Diff line change
Expand Up @@ -599,7 +599,7 @@ impl ReplicationSend for ConnectionManager {
mod tests {
use crate::prelude::{client, server, ClientConnectionManager};
use crate::tests::protocol::EntityMessage;
use crate::tests::stepper::{BevyStepper, Step};
use crate::tests::stepper::BevyStepper;

/// Check that we can map entities from the local world to the remote world
/// using the ConnectionManager
Expand Down
2 changes: 1 addition & 1 deletion lightyear/src/client/input/leafwing.rs
Original file line number Diff line number Diff line change
Expand Up @@ -809,7 +809,7 @@ mod tests {
use crate::prelude::server::Replicate;
use crate::prelude::{client, SharedConfig, TickConfig};
use crate::tests::protocol::*;
use crate::tests::stepper::{BevyStepper, Step};
use crate::tests::stepper::BevyStepper;

fn build_stepper_with_input_delay(delay_ticks: u16) -> BevyStepper {
let frame_duration = Duration::from_millis(10);
Expand Down
2 changes: 1 addition & 1 deletion lightyear/src/client/interpolation/interpolate.rs
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,7 @@ pub(crate) fn interpolate<C: Component + Clone>(
// use crate::prelude::client::*;
// use crate::prelude::*;
// use crate::tests::protocol::*;
// use crate::tests::stepper::{BevyStepper, Step};
// use crate::tests::stepper::{BevyStepper};
//
// fn setup() -> (BevyStepper, Entity, Entity) {
// let frame_duration = Duration::from_millis(10);
Expand Down
2 changes: 1 addition & 1 deletion lightyear/src/client/interpolation/visual_interpolation.rs
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ mod tests {

use crate::prelude::{SharedConfig, TickConfig};
use crate::tests::protocol::*;
use crate::tests::stepper::{BevyStepper, Step};
use crate::tests::stepper::BevyStepper;

use super::*;

Expand Down
2 changes: 1 addition & 1 deletion lightyear/src/client/message.rs
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ pub(crate) fn add_client_receive_message_from_server<M: Message>(app: &mut App)
mod tests {
use super::*;
use crate::serialize::writer::Writer;
use crate::tests::host_server_stepper::{HostServerStepper, Step};
use crate::tests::host_server_stepper::HostServerStepper;
use crate::tests::protocol::{Channel1, StringMessage};
use bevy::prelude::{EventReader, Resource, Update};

Expand Down
2 changes: 1 addition & 1 deletion lightyear/src/client/networking.rs
Original file line number Diff line number Diff line change
Expand Up @@ -542,7 +542,7 @@ mod tests {
use crate::{
client::config::ClientConfig,
prelude::{client::ClientCommands, server::*, SharedConfig, TickConfig},
tests::host_server_stepper::{HostServerStepper, Step},
tests::host_server_stepper::HostServerStepper,
};

#[derive(Resource, Default)]
Expand Down
2 changes: 1 addition & 1 deletion lightyear/src/client/prediction/despawn.rs
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ pub(crate) fn remove_despawn_marker(
// use crate::prelude::client::*;
// use crate::prelude::*;
// use crate::tests::protocol::*;
// use crate::tests::stepper::{BevyStepper, Step};
// use crate::tests::stepper::{BevyStepper};
// use bevy::prelude::*;
// use bevy::utils::Duration;
//
Expand Down
2 changes: 1 addition & 1 deletion lightyear/src/client/prediction/pre_prediction.rs
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ mod tests {
use crate::tests::protocol::{
ComponentSyncModeFull, ComponentSyncModeOnce, ComponentSyncModeSimple,
};
use crate::tests::stepper::{BevyStepper, Step, TEST_CLIENT_ID};
use crate::tests::stepper::{BevyStepper, TEST_CLIENT_ID};

/// Simple preprediction case
#[test]
Expand Down
2 changes: 1 addition & 1 deletion lightyear/src/client/prediction/predicted_history.rs
Original file line number Diff line number Diff line change
Expand Up @@ -338,7 +338,7 @@ mod tests {
use super::*;
use crate::prelude::client::RollbackState;
use crate::tests::protocol::*;
use crate::tests::stepper::{BevyStepper, Step};
use crate::tests::stepper::BevyStepper;
use crate::utils::ready_buffer::ItemWithReadyKey;
use bevy::ecs::system::RunSystemOnce;

Expand Down
2 changes: 1 addition & 1 deletion lightyear/src/client/prediction/prespawn.rs
Original file line number Diff line number Diff line change
Expand Up @@ -452,7 +452,7 @@ mod tests {

use crate::prelude::*;
use crate::tests::protocol::*;
use crate::tests::stepper::{BevyStepper, Step};
use crate::tests::stepper::BevyStepper;
use crate::utils::ready_buffer::ItemWithReadyKey;

#[test]
Expand Down
4 changes: 2 additions & 2 deletions lightyear/src/client/prediction/rollback.rs
Original file line number Diff line number Diff line change
Expand Up @@ -598,7 +598,7 @@ mod unit_tests {
use super::*;

use crate::tests::protocol::ComponentSyncModeFull;
use crate::tests::stepper::{BevyStepper, Step};
use crate::tests::stepper::BevyStepper;
use bevy::ecs::system::RunSystemOnce;

// TODO: check that if A is updated but B is not, and A and B are in the same replication group,
Expand Down Expand Up @@ -757,7 +757,7 @@ mod integration_tests {

use crate::prelude::client::*;
use crate::tests::protocol::*;
use crate::tests::stepper::{BevyStepper, Step};
use crate::tests::stepper::BevyStepper;
use bevy::prelude::*;

fn increment_component(
Expand Down
2 changes: 1 addition & 1 deletion lightyear/src/client/replication.rs
Original file line number Diff line number Diff line change
Expand Up @@ -537,7 +537,7 @@ pub(crate) mod send {
server, ClientId, DisabledComponent, ReplicateOnceComponent, Replicated, TargetEntity,
};
use crate::tests::protocol::ComponentSyncModeFull;
use crate::tests::stepper::{BevyStepper, Step, TEST_CLIENT_ID};
use crate::tests::stepper::{BevyStepper, TEST_CLIENT_ID};

#[test]
fn test_entity_spawn() {
Expand Down
2 changes: 1 addition & 1 deletion lightyear/src/client/sync.rs
Original file line number Diff line number Diff line change
Expand Up @@ -566,7 +566,7 @@ mod tests {
use crate::prelude::*;
use crate::server::events::InputEvent;
use crate::tests::protocol::*;
use crate::tests::stepper::{BevyStepper, Step};
use crate::tests::stepper::BevyStepper;

use super::*;

Expand Down
2 changes: 1 addition & 1 deletion lightyear/src/server/clients.rs
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ mod tests {
use crate::server::clients::ControlledEntities;
use crate::server::replication::send::Lifetime;
use crate::tests::multi_stepper::{MultiBevyStepper, TEST_CLIENT_ID_1, TEST_CLIENT_ID_2};
use crate::tests::stepper::{BevyStepper, Step, TEST_CLIENT_ID};
use crate::tests::stepper::{BevyStepper, TEST_CLIENT_ID};
use bevy::ecs::entity::EntityHashMap;
use bevy::prelude::{default, Entity, With};

Expand Down
2 changes: 2 additions & 0 deletions lightyear/src/server/connection.rs
Original file line number Diff line number Diff line change
Expand Up @@ -307,6 +307,7 @@ impl ConnectionManager {
channel: ChannelKind,
target: NetworkTarget,
) -> Result<(), ServerError> {
dbg!(&target);
self.connections
.iter_mut()
.filter(|(id, _)| target.targets(id))
Expand All @@ -316,6 +317,7 @@ impl ConnectionManager {
if c.is_local_client() {
c.local_messages_to_send.push(message.clone())
} else {
dbg!("sending resource message2");
// NOTE: this clone is O(1), it just increments the reference count
c.buffer_message(message.clone(), channel)?;
}
Expand Down
2 changes: 1 addition & 1 deletion lightyear/src/server/input/leafwing.rs
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ mod tests {
use crate::prelude::client;
use crate::prelude::server::*;
use crate::tests::protocol::*;
use crate::tests::stepper::{BevyStepper, Step};
use crate::tests::stepper::BevyStepper;

#[test]
fn test_leafwing_inputs() {
Expand Down
2 changes: 1 addition & 1 deletion lightyear/src/server/message.rs
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ pub(crate) fn add_server_receive_message_from_client<M: Message>(app: &mut App)
#[cfg(test)]
mod tests {
use crate::prelude::NetworkTarget;
use crate::tests::host_server_stepper::{HostServerStepper, Step};
use crate::tests::host_server_stepper::HostServerStepper;
use crate::tests::protocol::{Channel1, StringMessage};
use bevy::app::Update;
use bevy::prelude::{EventReader, ResMut, Resource};
Expand Down
2 changes: 1 addition & 1 deletion lightyear/src/server/relevance/room.rs
Original file line number Diff line number Diff line change
Expand Up @@ -495,7 +495,7 @@ mod tests {
};
use crate::server::relevance::immediate::{CachedNetworkRelevance, ClientRelevance};
use crate::shared::replication::components::NetworkRelevanceMode;
use crate::tests::stepper::{BevyStepper, Step};
use crate::tests::stepper::BevyStepper;

use super::systems::buffer_room_relevance_events;

Expand Down
4 changes: 2 additions & 2 deletions lightyear/src/server/replication.rs
Original file line number Diff line number Diff line change
Expand Up @@ -986,7 +986,7 @@ pub(crate) mod send {
use crate::shared::replication::systems;
use crate::tests::multi_stepper::{MultiBevyStepper, TEST_CLIENT_ID_1, TEST_CLIENT_ID_2};
use crate::tests::protocol::*;
use crate::tests::stepper::{BevyStepper, Step, TEST_CLIENT_ID};
use crate::tests::stepper::{BevyStepper, TEST_CLIENT_ID};
use bevy::ecs::system::RunSystemOnce;
use bevy::prelude::{default, EventReader, Resource, Update};
use bevy::utils::HashSet;
Expand Down Expand Up @@ -3040,7 +3040,7 @@ pub(crate) mod commands {

use crate::prelude::server::Replicate;
use crate::tests::protocol::*;
use crate::tests::stepper::{BevyStepper, Step};
use crate::tests::stepper::BevyStepper;

use super::*;

Expand Down
2 changes: 1 addition & 1 deletion lightyear/src/shared/replication/entity_map.rs
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ mod tests {
use crate::prelude::server::Replicate;
use crate::prelude::*;
use crate::tests::protocol::*;
use crate::tests::stepper::{BevyStepper, Step};
use crate::tests::stepper::BevyStepper;

// An entity gets replicated from server to client,
// then a component gets removed from that entity on server,
Expand Down
2 changes: 1 addition & 1 deletion lightyear/src/shared/replication/hierarchy.rs
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,7 @@ mod tests {
use crate::shared::replication::components::ReplicateHierarchy;
use crate::shared::replication::hierarchy::ParentSync;
use crate::tests::protocol::*;
use crate::tests::stepper::{BevyStepper, Step};
use crate::tests::stepper::BevyStepper;

fn setup_hierarchy() -> (BevyStepper, Entity, Entity, Entity) {
let mut stepper = BevyStepper::default();
Expand Down
Loading
Loading