Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Pre-Prediction #598

Merged
merged 3 commits into from
Aug 17, 2024
Merged

Fix Pre-Prediction #598

merged 3 commits into from
Aug 17, 2024

Conversation

cBournhonesque
Copy link
Owner

  • PrePrediction was broken since the introduction of send-side entity mapping.
    That's because:
  • client spawns predicted E1 and replicates it to server.
  • server spawns E2 and maintains mapping E2<>E1 and replicates it to client
  • client spawns confirmed E3 and maintains mapping E2<>E3.

With sender-side mapping, updates related to E2 would be mapped to E1 before being sent.

This PR fixes this problem, and it also works in host-server mode and with hierarchy.

Also fixes:

  • the replication_groups example was failing because of a erroneous check in the protocol
  • the connect/disconnect systems were running twice (both the normal and the host-server versions were running)
  • the server doesn't replicate Spawns to the entity that first spawned an entity.

@cBournhonesque cBournhonesque added C-Bug Something isn't working A-Prediction labels Aug 17, 2024
@cBournhonesque cBournhonesque merged commit 880d9df into main Aug 17, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Prediction C-Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant