Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not init empty arrays #321

Merged
merged 1 commit into from
Aug 7, 2024
Merged

fix: do not init empty arrays #321

merged 1 commit into from
Aug 7, 2024

Conversation

caarlos0
Copy link
Owner

@caarlos0 caarlos0 commented Aug 6, 2024

fix #320

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Copy link

codecov bot commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (68793c0) to head (6db39d4).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #321   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines          498       499    +1     
=========================================
+ Hits           498       499    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@caarlos0
Copy link
Owner Author

caarlos0 commented Aug 7, 2024

@Rancbar when you can please take a look 🙏🏻

@Rancbar
Copy link
Contributor

Rancbar commented Aug 7, 2024

@Rancbar when you can please take a look 🙏🏻

Great, Thanks 💯

@caarlos0 caarlos0 merged commit 2683e95 into main Aug 7, 2024
16 checks passed
@caarlos0 caarlos0 deleted the 320 branch August 7, 2024 12:18
BorzdeG pushed a commit to BorzdeG/env that referenced this pull request Aug 24, 2024
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non-existing variable of type slice of structs is mapped to an empty slice instead of nil
2 participants